Opened 11 years ago
Closed 11 years ago
#11098 closed Bug (fixed)
Wrong selection after undoing DnD
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3 |
| Component: | General | Version: | 4.3 |
| Keywords: | Cc: |
Description
Follow up for #10933.
- Open image2 sample.
- Drag widget.
- Undo - selection is lost or placed at the end of editable.
It concerns both - block and inline widgets.
Change History (4)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | new → review |
I pushed a t/11098 on dev and test.
It fixes both - inline and block widgets DnD integration with undo manager. The rule of thumb is - when undid DnD widget should be focused. The same when redid.
There's an issue on IEs though, that when redoing block widget DnD selection is moved to the the element which is before widget. It seems that addresses of bookmark's ends are not normalized correctly, or that there's a non-empty node which is not restored after loading snapshot's HTML. So it's a separate issue.
comment:3 Changed 11 years ago by
| Milestone: | → CKEditor 4.3 |
|---|---|
| Status: | review → review_passed |
comment:4 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on major with git:700ffd9 on dev and e1d6c74 on tests.
Note: See
TracTickets for help on using
tickets.
cc