Opened 10 years ago

Closed 10 years ago

#11098 closed Bug (fixed)

Wrong selection after undoing DnD

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.3
Component: General Version: 4.3
Keywords: Cc:


Follow up for #10933.

  1. Open image2 sample.
  2. Drag widget.
  3. Undo - selection is lost or placed at the end of editable.

It concerns both - block and inline widgets.

Change History (4)

comment:1 Changed 10 years ago by Olek Nowodziński


comment:2 Changed 10 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newreview

I pushed a t/11098 on dev and test.

It fixes both - inline and block widgets DnD integration with undo manager. The rule of thumb is - when undid DnD widget should be focused. The same when redid.

There's an issue on IEs though, that when redoing block widget DnD selection is moved to the the element which is before widget. It seems that addresses of bookmark's ends are not normalized correctly, or that there's a non-empty node which is not restored after loading snapshot's HTML. So it's a separate issue.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 4.3
Status: reviewreview_passed

comment:4 Changed 10 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on major with git:700ffd9 on dev and e1d6c74 on tests.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy