Opened 5 years ago

Closed 5 years ago

#11202 closed Bug (fixed)

No newline at BB-code mode

Reported by: Dennis1993 Owned by: Piotr Jasiun
Priority: Must have (possibly next milestone) Milestone: CKEditor 4.3.1
Component: Core : Output Data Version: 4.3
Keywords: Cc:

Description

I've upgraded my CK-Editor to 4.3.

Since I can do no more newline. After saving everything is in one line. In the demo here on ckeditor.com that does not work.

Test it: http://ckeditor.com/demo#bbcode

Reproduce:

  • Write a text with multiple line breaks
  • Click on Source code
  • You can see, that all text is in one line

The editor is thus completely useless! Please fix it quickly!

THANKS!

Change History (9)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.3.1
Status: newconfirmed

Confirmed.

Simple workaround for now - add this to config:

config.enterMode = CKEDITOR.ENTER_BR

comment:2 Changed 5 years ago by Piotrek Koszuliński

Priority: NormalHigh

comment:3 Changed 5 years ago by Dennis1993

Hey Reinmar,

thanks for your answer. I have added your workaround and it works. I hope you can fix it in next version!

Thank you very much!

comment:4 Changed 5 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedassigned

comment:5 Changed 5 years ago by Piotr Jasiun

Status: assignedreview

BBCode plugin should set editor.activeEnterMode instead of editor.config.enterMode.

Changes in t/11202 and corresponding test branch.

comment:6 Changed 5 years ago by Marek Lewandowski

Summary: No newline at BB-code mode possible!!!!No newline at BB-code mode

comment:7 Changed 5 years ago by Olek Nowodziński

Status: reviewreview_passed

Rebased branch on latest master.

Pushed two commits:

  • Explained the change.
  • Reverted the extension of config#enterMode for backwards compatibilty so
    [ CKEDITOR.instances.editor1.config.enterMode, CKEDITOR.instances.editor1.enterMode, CKEDITOR.instances.editor1.activeEnterMode ].join( ', ' );
    > "2, 2, 2"
    

when running plugins/bbcode/samples/bbcode.html. Some people may combine bbcode plugin with 3rd party plugins that still rely on config#enterMode; better not break that dependency (yet).

comment:8 Changed 5 years ago by Piotr Jasiun

comment:9 Changed 5 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy