Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11222 closed Task (fixed)

Integration of Image and Image2

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Must have (possibly next milestone) Milestone: CKEditor 4.3.1
Component: General Version: 4.3 Beta
Keywords: Cc:

Description

Following #11201:

  • Image and image2 got to share command, button, dialog and other names.
  • The "old image" plugin should detect whether image2 is loaded: if so it will stay disabled.

Obstacles:

  • The way the image plugin is disabled.
  • The dependency between image plugin and "image button" (forms).
  • Testing stuff. I.e. it's already been noticed that if a build contains image, image2 and forms, "image button" works fine even though image plugin is not initialized.
  • The less people will have troubles because of that change, the better.

Change History (11)

comment:1 Changed 5 years ago by Olek Nowodziński

Priority: NormalHigh

comment:2 Changed 5 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:3 Changed 5 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:4 Changed 5 years ago by Olek Nowodziński

Status: assignedreview

Created branch t/11222 in dev:

  1. Renamed:
    • Dialog
    • Button
    • Context menu
    • CSS classes
    • The widget
    • Icons
    • Helpers
  2. Simplified samples (also dev):
    • Removed removePlugins: 'image,forms'
  3. Forced "image" plugins and "ImageButton" to turn off when "image2" is detected.

Created branch t/11222 in tests:

  1. Aligned "image2" tests to new names.
  2. Added dt/plugins/image2/relations.html to make sure 3. from the list above really works.

comment:5 Changed 5 years ago by Piotrek Koszuliński

Do we still need this?

	config.filebrowserImage2BrowseUrl = config.filebrowserImageBrowseUrl;
	config.filebrowserImage2UploadUrl = config.filebrowserImageUploadUrl;

comment:6 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_failed

We decided to revert the name of image2's dialog to image2, so it will be possible to use both plugins on one page with multiple editors.

comment:7 in reply to:  6 Changed 5 years ago by Olek Nowodziński

Status: review_failedreview

Replying to Reinmar:

We decided to revert the name of image2's dialog to image2, so it will be possible to use both plugins on one page with multiple editors.

Done. Tests should match.

Also:

comment:8 Changed 5 years ago by Matti Järvinen

Depends on #10931 Allow nesting widgets?

comment:9 Changed 5 years ago by Piotrek Koszuliński

@matti: Nesting widgets is not a requirement for this ticket. This ticket is mostly about the naming and having the image2 disabling image if both are loaded.

comment:10 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_passed

I forced pushed branches with one commit removed in each. We cannot rename CKEDITOR.plugins.image2 to image too.

I checked how both plugins work together, on one page and it's ok. Tests for full-all build pass to.

comment:11 Changed 5 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

git:18df3e2 landed in master (dev), 805d7ac (tests).

Last edited 5 years ago by Olek Nowodziński (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy