Opened 10 years ago

Last modified 10 years ago

#11300 closed Task

Image2: polishing and refactoring of internals — at Version 2

Reported by: Olek Nowodziński Owned by:
Priority: Normal Milestone: CKEditor 4.4.0
Component: General Version: 4.3
Keywords: Drupal Cc: wim.leers@…

Description (last modified by Olek Nowodziński)

Some refactoring got to be done to make Image2 flexible and "environment-friendly". Those changes are relevant for third-party developers, e.g. for D8.

  1. The internal form of the widget got to be styleable: instead of inline styles, we need to introduce classes. With inline styles, the look of the widget is not configurable and possibly incompatible with custom stylesheets during editor's lifetime.
    1. The non-captioned image should have no class.
    2. The class of captioned image must be configurable via config.image2_captionedClass and applied to <figure class="...">.
    3. Class "caption" is obsolete so it will be removed.
    4. Alignment also must be controlled with classes.
    5. Tons of tests to be aligned to the new API.
  1. We should guarantee that additional attributes (e.g. data-*) are preserved, regardless of the internal state of the widget. Extra attributes must survive any kind of internal processing and re-emerge in editor's output (1:1).
    1. Quite likely it's already working because the image node in DOM is passed along with states of a widget (needs tests).
    2. Alternatively, attributes can be serialized in upcast, saved in widget's data and exploded while downcasting. But let's stick to (a) as an easiest "solution" first.

Change History (2)

comment:1 Changed 10 years ago by Olek Nowodziński

Description: modified (diff)
Summary: Image2 in D8Image2: polishing and refactoring of internals

comment:2 Changed 10 years ago by Olek Nowodziński

Description: modified (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy