Opened 5 years ago

Last modified 5 years ago

#11334 confirmed Bug

CKEditor adds a space after the "cke_dialog_ui_input_textarea" class

Reported by: Sudhindra Rao Owned by:
Priority: Low Milestone:
Component: General Version: 4.1
Keywords: Cc:

Description

We just upgraded to the latest version of ckeditor and downloaded the minified version.

Everything worked fine except for places where textarea are created we see the problem trying to access "cke_dialog_ui_input_textarea". We looked at the code and found that one place ckeditor does the following

fclass?="cke_dialog_ui_input_textarea "+(aclass?
"")

Having this line causes the class="cke_dialog_ui_input_textarea " with an extra whitespace when aclass? is undefined. This caused our tests with sahi to fail since sahi was not able to find anything with the exact class name. We have reported the bug with sahi as well.

But attached is the patch that can fix it for the ckeditor.

Hope this works for ckeditor and helps.

-Thanks Sudhindra

Attachments (1)

ckeditor_whitespace.patch (4.9 KB) - added by Sudhindra Rao 5 years ago.
ckeditor_whitespace fix

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Sudhindra Rao

Attachment: ckeditor_whitespace.patch added

ckeditor_whitespace fix

comment:1 Changed 5 years ago by Frederico Caldeira Knabben

Thanks for the patch. Unfortunately it is not of much help as targets the minified release code of CKEditor. A more effective way to contribute is through pull requests in the official CKEditor dev repository.

comment:2 Changed 5 years ago by Frederico Caldeira Knabben

Priority: NormalLow

In any case, you should also trac this issue on the sahi side as there is nothing wrong on having that space in the class attribute.

comment:3 Changed 5 years ago by Piotrek Koszuliński

Status: newconfirmed
Summary: ckeditor version 4.3.1 adds a space after the "cke_dialog_ui_input_textarea"CKEditor adds a space after the "cke_dialog_ui_input_textarea" class
Version: 4.3.1

I removed the version, because the space is there definitely longer.

comment:4 Changed 5 years ago by Jakub Ś

Version: 4.1

"cke_dialog_ui_input_textarea " has first appeared in CKE 4.1

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy