Opened 11 years ago
Last modified 11 years ago
#11365 confirmed Bug
Blink crashes if right clicking on mapped image
Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | UI : Context Menu | Version: | 3.6.6 |
Keywords: | Blink | Cc: |
Description (last modified by )
Set allowed content to true and then insert an image map in the content:
<img alt="" src="assets/sample.jpg" usemap="#imgmap201414175321zz" /> <map id="imgmap201414175321zz" name="imgmap201414175321zz"><area coords="5,5,155,195" href="page.html" shape="rect" /></map>
Now right click on the map with the developer tools open and the tab will crash in Chrome. Adding a check in the tabletools plugin seems to be enough:
From
editor.contextMenu.addListener( function( element, selection, path ) { var cell = path.contains( { 'td': 1, 'th': 1 }, 1 ); if ( cell && !cell.isReadOnly() ) {
To
editor.contextMenu.addListener( function( element, selection, path ) { var cell = path && path.contains( { 'td': 1, 'th': 1 }, 1 ); if ( cell && !cell.isReadOnly() ) {
Despite this patch, I've already filed a ticket in Chrome, but this patch will avoid getting the error. https://code.google.com/p/chromium/issues/detail?id=331664
Related issue: #11308.
Attachments (1)
Change History (10)
comment:1 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 11 years ago by
comment:3 follow-up: 6 Changed 11 years ago by
Keywords: | Blink added |
---|---|
Status: | new → confirmed |
Summary: | Chrome crashes if right clicking on mapped image → Blink crashes if right clicking on mapped image |
@alfonsoml original problem you mention can be reproduced from CKEditor 3.0 and this is indeed a browser bug because it doesn't need editor to crash browser (same thing happens in contenteditable).
- IMHO It would be good idea to add this workaround until Chrome fixes this issue on its side.
- There is however CKE specific issue that can be reproduced from CKEditor 4.0 beta. To reproduce it:
- use full package
- set allowedContent:true,
- insert code provided by @alfonsoml,
- switch to wysiwyg
- right-click on image
comment:4 Changed 11 years ago by
Milestone: | → CKEditor 4.3.2 |
---|
comment:5 Changed 11 years ago by
Owner: | set to Olek Nowodziński |
---|---|
Status: | confirmed → assigned |
comment:6 Changed 11 years ago by
Replying to j.swiderski:
@alfonsoml original problem you mention can be reproduced from CKEditor 3.0 and this is indeed a browser bug because it doesn't need editor to crash browser (same thing happens in contenteditable).
Yes, of course a crash is always a severe browser bug, and that's why I first reported it to them and only wrote this ticket in order to fix a little issue, but it doesn't really fix the problem.
The strange thing in your comment is the part that it also happens in plain contenteditable because that seemed to work fine in my tests and so I had to provide a complex testcase with all the core of CKEditor. I might try again to reproduce it in order to provide them a simplified testcase.
comment:7 Changed 11 years ago by
Milestone: | CKEditor 4.3.2 |
---|---|
Owner: | Olek Nowodziński deleted |
Status: | assigned → confirmed |
Version: | 4.3.1 → 3.6.6 (SVN - trunk) |
Unfortunately, the solution proposed by the author is not valid. The issue has nothing to do with Tabletools plugin and can be reproduced with config.plugins = 'wysiwygarea,contextmenu'
(see attached sandbox). Everything is up to Chrome dev team in such case.
comment:8 Changed 11 years ago by
I confirm this. Adding a check does not help.
Another user reported us a similar issue #11380 but with select elements.
comment:9 Changed 11 years ago by
Description: | modified (diff) |
---|
Please, note that this seems to avoid the crash only in inline editing, the iframe crashes more often, but at least it's a start.