Opened 7 years ago

Last modified 7 years ago

#11479 review Task

env.ieQuirks — at Version 3

Reported by: Piotr Jasiun Owned by: Piotr Jasiun
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description (last modified by Piotr Jasiun)

The problem with quirks appeared after removing IE 6 & IE 7 support (#11422), because most of hacks now apply only to QM (instead of IE 7, IE 6 and IE QM). Even worse it is implemented in multipile ways (unsing " && env.quirks", "env.ie6Compat" or "document.documentMode").

I think that it would be misleading if we keep if ( env.ie6Compat ) in our code only because of QM (env.ie6Compat is true in QM) and it is better to replace it with if ( env.ieQuirks ).

Also after clean up we can save some bites (compressed ckeditor is 322 byts smaller with env.ieQuirks).

I'm not sure if there is a point in keeping env.quirks == true for non-IE browsers. Maybe env.quirks should be true only in IE 8 and IE 9 QM (as env.ieQuirks works now).

Change History (3)

comment:1 Changed 7 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: newassigned

comment:2 Changed 7 years ago by Piotr Jasiun

Status: assignedreview

Changes in t/11479. It is based on t/11422.

comment:3 Changed 7 years ago by Piotr Jasiun

Description: modified (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy