Opened 10 years ago
Last modified 10 years ago
#11479 review Task
env.ieQuirks — at Version 4
| Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description (last modified by )
The problem with quirks appeared after removing IE 6 & IE 7 support (#11422), because most of hacks now apply only to QM (instead of IE 7, IE 6 and IE QM). Even worse it is implemented in multipile ways (unsing "env.ie && env.quirks", "env.ie6Compat" or "document.documentMode").
I think that it would be misleading if we keep if ( env.ie6Compat ) in our code only because of QM (env.ie6Compat is true in QM) and it is better to replace it with if ( env.ieQuirks ).
Also after clean up we can save some bites (compressed ckeditor is 322 byts smaller with env.ieQuirks).
I'm not sure if there is a point in keeping env.quirks == true for non-IE browsers. Maybe env.quirks should be true only in IE 8 and IE 9 QM (so we will use just env.quirks instead of env.ieQuirks).
Change History (4)
comment:1 Changed 10 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | new → assigned |
comment:2 Changed 10 years ago by
| Status: | assigned → review |
|---|
comment:3 Changed 10 years ago by
| Description: | modified (diff) |
|---|
comment:4 Changed 10 years ago by
| Description: | modified (diff) |
|---|
Changes in t/11479. It is based on t/11422.