Opened 5 years ago

Closed 5 years ago

#11568 closed Bug (fixed)

Styles Combo: Select combo list is disabled when only object styles are defined

Reported by: mmikitka Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.3.4
Component: Core : Styles Version: 4.3
Keywords: Support Cc:

Description

Descriptive summary

If one only supplies object styles to config.styleSet, the Styles select combo list remains disabled, even when an object supporting at least one of the defined styles is selected.

Steps to reproduce

  1. Use a config.styleSet definition like the following, which only contains object styles:

CKEDITOR.config.stylesSet = [

{ name: 'Square Bulleted List', element: 'ul', styles: { 'list-style-type': 'square' } }

];

  1. Reload CKEditor
  1. Create a bulleted list
  1. The Select list remains disabled

Browser and OS Tested on Chrome and Firefox on Ubuntu 12.04.03

Screenshot Not included

Sample data See config.styleSet definition above

Test case file None

Build configuration None

Attachments (1)

replacebycodex.html (6.5 KB) - added by Jakub Ś 5 years ago.

Download all attachments as: .zip

Change History (10)

comment:2 Changed 5 years ago by Jakub Ś

Status: newconfirmed
Version: 4.3.3 (GitHub - master)4.3

I was able to reproduce this problem from CKEditor 4.3 in all browsers except for IE. Yes, for change IE is the only working browser, while others are failing.

NOTE: this doesn't happen in 4.3 beta.

Changed 5 years ago by Jakub Ś

Attachment: replacebycodex.html added

comment:3 Changed 5 years ago by Jakub Ś

Keywords: Support added

comment:4 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.3.4

comment:5 Changed 5 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedassigned

comment:6 Changed 5 years ago by Piotr Jasiun

First bad commit is 7511404.

comment:7 Changed 5 years ago by Piotr Jasiun

Status: assignedreview

Working on #10848 we were sure that the state of style combo can change only when active filter changes or mode changes so I removed updateState method from the list of selectionChange listeners. It appears to be a mistake. I reverted that change and added tests.

Changes in t/11568 and corresponding test branch.

comment:8 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_passed

Kudos!

I force-pushed both rebased branches + some small fixes.

comment:9 Changed 5 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy