Opened 11 years ago
Closed 10 years ago
#11583 closed New Feature (fixed)
Add support for HTML5 "required" attribute in form input elements
| Reported by: | Urs Wolfer | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
| Component: | UI : Dialogs | Version: | 3.6.6 |
| Keywords: | Cc: |
Description
It would be nice to have a checkbox for setting the required attribute for form elements.
Change History (10)
comment:1 Changed 11 years ago by
| Keywords: | forms required validation removed |
|---|---|
| Status: | new → confirmed |
| Summary: | Add support for HTML5 "required" tag in form elements → Add support for HTML5 "required" attribute in form input elements |
comment:2 Changed 11 years ago by
Just to make it more clear: I'm talking about a checkbox in the forms plugin for each input field to enable / disable the required flag.
comment:5 Changed 11 years ago by
Replying to matti:
Nice... optional placeholder while you're at it?
I'd like to get this merged first. Please open a new feature request for placeholder tests (if there does not exist one yet).
comment:6 Changed 10 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:7 Changed 10 years ago by
| Status: | assigned → review |
|---|
I extracted the code from https://github.com/ckeditor/ckeditor-dev/pull/100 to branch:t/11583 and thoroughly reviewed it. Changes include:
- Tests separated from dev code.
- Improved code style.
- Some new and improved tests.
- A different
accessKeyfor "required" field. I decided that it got to correspond with our naming pattern, so it's "R". I also checked whether it collides with browser keystrokes but it seems to be fine.
comment:8 Changed 10 years ago by
I pushed branch:t/11583 rebased on major (since it's a feature).
I agree with this comment that in this case 'Q' may be a choice.
I made just a brief check and I'm ok with the changes.
comment:9 Changed 10 years ago by
| Component: | General → UI : Dialogs |
|---|---|
| Milestone: | → CKEditor 4.5.0 |
| Status: | review → review_passed |
| Version: | → 3.6.6 |
Fixed in git:a067471.
comment:10 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
We have done it for base textarea that classic CKEditor is using (#8031) so it would be nice to add such field to input form elements CKEditor handles.