Opened 6 years ago

Closed 6 years ago

#11597 closed Bug (fixed)

[IE11] Error thrown when trying to open preview using keyboard

Reported by: Piotrek Koszuliński Owned by: Marek Lewandowski
Priority: Normal Milestone: CKEditor 4.3.4
Component: General Version: 4.3.2
Keywords: Cc:

Description (last modified by Marek Lewandowski)

  1. open any sample with CKEditor (i.e. samples/replacebyclass.html)
  2. focus editor
  3. press alt+f10 to focus toolbar
  4. navigate to preview button
  5. press button using space

Related issue: #11408.

Our goal is to avoid exception. Popup blocker thing is another issue.

Change History (7)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 6 years ago by Marek Lewandowski

Owner: set to Marek Lewandowski
Status: confirmedassigned

comment:3 Changed 6 years ago by Marek Lewandowski

Status: assignedreview

Commit which caused the issue: git:93803693adf82d3467f926a68325904b3a360f3b

With that commit we started to use window.location (for IE) to assign that tricky js code (instead of passing it to window.open). I created a trivial fix which prevents the exception from being thrown.

Pushed to t/11597 at dev.

comment:4 Changed 6 years ago by Marek Lewandowski

Description: modified (diff)

comment:5 Changed 6 years ago by Piotr Jasiun

I tested it and everything works fine now (on Windows 7 and Windows 8.1).

Last edited 6 years ago by Piotr Jasiun (previous) (diff)

comment:6 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_passed

comment:7 Changed 6 years ago by Marek Lewandowski

Resolution: fixed
Status: review_passedclosed

Fixed with git:7838eb1c98 (merged to master) at dev.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy