Opened 5 years ago

Last modified 5 years ago

#11625 review New Feature

Start using different hashes instead of timestamp for loading resources (via getUrl)

Reported by: Wiktor Walc Owned by: Artur Delura
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

Using timestamp to mark unique builds worked fine in the past where we released packages once per ~month.

Now, when lots of users try different builds, overwriting the same location and then scratching their heads why something does not work, we need to do something different. See for example http://ckeditor.com/forums/CKEditor/Bug-with-custom-builder-and-language-selection, there were more issues reported like this.

My suggestion is to go with assigning a random hash when creating a build. There is no sense in calculating the hash based on the list of enabled plugins (and their versions, btw. we do not have this information in case of using command line builder), languages etc. Using a hash that is complex enough will do the trick.

Using 6-characters long hash that consists of small letters + numbers, gives ~1 838 265 625 (35^6) combinations if I counted correctly (1.8 billion).

Change History (5)

comment:1 Changed 5 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 5 years ago by Wiktor Walc

#10335 was marked as duplicate

comment:3 Changed 5 years ago by Wiktor Walc

#10685 is quite related, once we introduce hashes we should also use them for URLs in CSS files

Last edited 5 years ago by Jakub Ś (previous) (diff)

comment:4 Changed 5 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:5 Changed 5 years ago by Artur Delura

Status: assignedreview
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy