Opened 11 years ago

Closed 11 years ago

#11626 closed Bug (fixed)

Tableresize sets invalid width

Reported by: Wiktor Walc Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.4.1
Component: Core : Tables Version:
Keywords: HasPatch Cc:

Description (last modified by Wiktor Walc)

When resizing a column to the maximum available width (by shrinking a column next to it), the width of the second column is set to 0, which is an invalid number.

When 0px is used, the column behaves like it did have width style set at all, while the fact is that user decided to resize it to the minimum. Setting 1px will preserve a narrow size of the column.

1) The moment of resizing a column

2) The second column has width set to 0px

		<tr>
			<td style="width: 238px;">&nbsp;</td>
			<td style="width: 0px;">&nbsp;</td>
			<td>&nbsp;</td>
			<td>&nbsp;</td>
		</tr>

3) The second column has width set to 1px

		<tr>
			<td style="width: 237px;">&nbsp;</td>
			<td style="width: 1px;">&nbsp;</td>
			<td>&nbsp;</td>
			<td>&nbsp;</td>
		</tr>

Attachments (4)

table-resize-cropped.png (22.8 KB) - added by Wiktor Walc 11 years ago.
tableresize-0-width.png (20.4 KB) - added by Wiktor Walc 11 years ago.
tableresize-1px-width.png (20.3 KB) - added by Wiktor Walc 11 years ago.
11626.patch (883 bytes) - added by Michal Vlcek 11 years ago.
Patch to plugins.tableresize.plugin.js

Download all attachments as: .zip

Change History (17)

Changed 11 years ago by Wiktor Walc

Attachment: table-resize-cropped.png added

Changed 11 years ago by Wiktor Walc

Attachment: tableresize-0-width.png added

Changed 11 years ago by Wiktor Walc

Attachment: tableresize-1px-width.png added

comment:1 Changed 11 years ago by Wiktor Walc

Description: modified (diff)

comment:2 Changed 11 years ago by Wiktor Walc

Status: newconfirmed

comment:3 Changed 11 years ago by Michal Vlcek

hi, i'lll do that if its still unassigned

comment:4 Changed 11 years ago by Michal Vlcek

patch included! now minimal column width is 1px.

Last edited 11 years ago by Michal Vlcek (previous) (diff)

Changed 11 years ago by Michal Vlcek

Attachment: 11626.patch added

Patch to plugins.tableresize.plugin.js

comment:5 Changed 11 years ago by Michal Vlcek

Keywords: HasPatch added

comment:6 Changed 11 years ago by Wiktor Walc

Milestone: CKEditor 4.4.1

comment:7 Changed 11 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedassigned

comment:8 Changed 11 years ago by Piotr Jasiun

Thank you for your changes vlcekmi3. They work fine. Changes in t/11626.

comment:9 Changed 11 years ago by Piotr Jasiun

Status: assignedreview

comment:10 Changed 11 years ago by Piotrek Koszuliński

Status: reviewreview_failed

This patch was also submitted in pull request - please use it: https://github.com/ckeditor/ckeditor-dev/pull/87

comment:11 Changed 11 years ago by Piotr Jasiun

Status: review_failedreview

Done. Changes in t/11626.

comment:12 Changed 11 years ago by Piotrek Koszuliński

Status: reviewreview_passed

I force pushed rebased branches with a simplified comment.

comment:13 Changed 11 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed

Merged into master with hash git:41e48b3

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy