Opened 17 years ago
Closed 17 years ago
#1171 closed Bug (fixed)
An insertion of any kind of INPUT element is not undoable.
Reported by: | Aleksey Onopriyenko | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | FCKeditor 2.5 Beta |
Component: | General | Version: | SVN (FCKeditor) - Retired |
Keywords: | Confirmed | Cc: |
Description
Steps to reproduce (for checkboxes, radiobuttons, etc).
- Load
sample01.html
- Set the cursor at the end of text.
- Press Checkbox button on the toolbar. A dialog window will appear.
- Fill the fields in and press Ok button.
A checkbox has been inserted but Undo button is disabled.
This can be fixed pretty easy by adding the following line in Ok function of the appropriate dialog window (see dialog/fck_table.html for example).
oEditor.FCKUndo.SaveUndoStep() ;
But I wonder if this behaviour is intentional.
Change History (4)
comment:1 Changed 17 years ago by
Keywords: | Confirmed added |
---|---|
Milestone: | → FCKeditor 2.5 |
Version: | → SVN |
comment:3 Changed 17 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Aleksey, with your fix, you are calling SaveUndoStep only when inserting new objects in the editor, but not when simply making changes to already existing things. I believe both actions must be undoable, even if in some cases the undo will not bring a visual effect (when changing a field name, for example). I think that call should be in the first line inside the Ok().
Is there any motivation for your choice?
comment:4 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
You are right. The both actions must be undoable.
Fixed with [778].
Those kinds of actions must certainly be undoable.