Opened 5 years ago

Closed 5 years ago

#11737 closed New Feature (fixed)

ACF callback to prevent filtering on matching element

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.4.0
Component: General Version:
Keywords: Cc:

Description

Required for #10925.

Explained in #11503.

Disabling ACF without a possibility to communicate through element's attributes. In this case the only possible solution is a callback executed by ACF which will notify it about how it should proceed. For example mediaembed will add a callback which will tell ACF that all descendants of element should be skipped if element has mediaembed's class. Callback will return binary flags, because we may need more options in the future. Example of flags that we may need to implement:

  • DISABLE_ON_ELEMENT - skips only this element (continues on descendants),
  • DISABLE_ON_DESCENDANTS - skips descendants,
  • CONTINUE_ITERATION - continue iteration - used with DISABLE_ON_DESCENDANTS could inform ACF that it should look for a descendant that reenables filtering,
  • ENABLE - reenable filtering.

But of course for now we'll need just one of these flags, so only one should be implemented.

Change History (5)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 5 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed branch:t/11737 on dev and tests.

comment:3 Changed 5 years ago by Olek Nowodziński

Rebased dev branch on latest major.

comment:4 Changed 5 years ago by Olek Nowodziński

Status: reviewreview_passed

comment:5 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Merged to major with git:58af051 on dev and fdff52b on tests.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy