Link in image caption is taken as link which wraps image

[Piotrek Koszuliński]

In image2 sample load:

<figure class="image"><img alt="Saturn V" src="assets/image1.jpg" width="200" />
<figcaption>Roll out <a href="x">of Saturn V</a> on launch pad</figcaption>
</figure>

Kaboom! The issue is caused by widget.parts.link discovering the link inside figcaption.

[Wim Leers]

I found and reported this.

And I think I've found the solution.

In the image2 plugin's widget definition:

			parts: {
				image: 'img',
				caption: 'figcaption',
				link: 'a'
			},

The widget plugin's setupParts() function calls

widget.wrapper.findOne( widget.parts[ partName ] );

This selects any a element inside the widget. Which causes the wrong a to be selected: the one in the caption.

So the solution is super simple: just update the selector!

			parts: {
				image: 'img',
				caption: 'figcaption',
				link: 'figure>a'
			},

[Olek Nowodziński]

It could be solved with the following selector if IE8 supported :not():

link: 'a[data-widget],*:not(figcaption)>a'

But it does not. Fix pushed to ​branch:t/11783 (tests).

[Olek Nowodziński]

Replying to a.nowodzinski:

It could be solved with the following selector if IE8 supported :not():

link: 'a[data-widget],*:not(figcaption)>a'

But it does not. Fix pushed to ​branch:t/11783 (+tests).

[Piotrek Koszuliński]

Thanks. R+, merged to major with ​git:e20ae7b on dev and 2a75dd9 on tests.