Opened 4 years ago

Closed 3 years ago

#11798 closed Bug (fixed)

Inserting non-editable element inside a table cell breaks the table badly

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.4.1
Component: General Version: 4.3
Keywords: Cc:

Description

  1. Open replacebycode sample.
  2. Place caret at the beginning or end of some table cell.
  3. Insert pagebreak.

Table is totally split. Reproduced on IE11 and Chrome.

Second TC:

  1. Open image2 sample.
  2. Insert table.
  3. Try to insert captioned image inside table cell (note: caret must be at the end or beginning of td).

The same - table is destroyed.

Change History (4)

comment:1 Changed 4 years ago by Jakub Ś

Status: newconfirmed

I was able to reproduce this problem in every browser from CKEditor 4.3.

The easiest scenario is to create new table in empty content are, putting focus into first table cell (if it isn't already there)and inserting page break or widget.

comment:2 Changed 3 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedreview

Interesting TC it was. I started in editable#insertElement, wrote tests, found range#fixBlock, wrote a lot of tests (was 0), found range#enlarge, wrote test. 1LOC change fixed it.

Code in branch:t/11798 on dev and tests.

comment:3 Changed 3 years ago by Marek Lewandowski

Status: reviewreview_passed

I've force pushed branches rebased on master. Everything works good.

comment:4 Changed 3 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on master with git:8c6d5e4 on dev and 609e037 on tests.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy