Opened 11 years ago
Closed 11 years ago
#11823 closed Bug (fixed)
[IE8] TableResize throws error over scrollbar
Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.4.1 |
Component: | General | Version: | 4.3.4 |
Keywords: | Cc: |
Description (last modified by )
- Open table-resize sample.
- Add some empty lines so the scrollbar will show.
- Drag last pillar and move it so the mouse will be over the scrollbar.
Result: Error multiple times in the console:
Object doesn't support this property or method
First bad commit: git:4991411.
I wasn't able to reproduce it on IE9, IE11 and Chrome.
Change History (9)
comment:1 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 11 years ago by
Milestone: | → CKEditor 4.4.1 |
---|
comment:3 Changed 11 years ago by
Status: | new → confirmed |
---|
comment:4 Changed 11 years ago by
Owner: | set to Piotr Jasiun |
---|---|
Status: | confirmed → assigned |
comment:5 Changed 11 years ago by
Status: | assigned → review |
---|
comment:6 Changed 11 years ago by
Status: | review → review_failed |
---|
I force pushed rebased branch with additional commit simplifying and clarifying the target validation.
However, R- because tabletools tests fail.
comment:7 Changed 11 years ago by
Status: | review_failed → review |
---|
I rebased branch, run tests and tabletools tests were green on IE8, FF and Chrome, but tableresize tests were red. If fixed those tests and pushed both branches.
comment:8 Changed 11 years ago by
Status: | review → review_passed |
---|
Ups, my fault - of course I meant tableresize tests.
comment:9 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
- git:c4a1982
- tests:2de1ed7
It was possible to reproduce this bug also on FF.
The reason was missing events target document when the mouse was outside the editor. We could switch back to using
editable
instead ofdocument
(see first bad commit) but the we would lost benefits of usingdocument
(withdocument
D&D works also below the body if body is small).I decided to check if events target document exist instead and cancel the event if it's not.
Changes in t/11823.