Opened 4 years ago

Closed 4 years ago

#11856 closed Task (fixed)

jQuery adapter should thrown an issue if CKEditor or jQuery are not loaded

Reported by: Piotrek Koszuliński Owned by: Artur Delura
Priority: Normal Milestone: CKEditor 4.5.0 Beta
Component: General Version: 4.1
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

Now we silently fail when jQ is not loaded and throw meaningless error if CKEditor is not loaded. It would be worth being more communicative, but that means changing logic a little bit (in case of missing jQ), so this change should not be shipped in minor release.

Change History (14)

comment:1 Changed 4 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:2 Changed 4 years ago by Olek Nowodziński

cc

comment:3 Changed 4 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:4 Changed 4 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:5 Changed 4 years ago by Artur Delura

Status: assignedreview

Changes and tests in branch:t/11856

comment:6 Changed 4 years ago by Piotr Jasiun

Status: reviewreview_failed

You created very good message if jQuery is missing, but missing CKEDITOR is not handled at all.

comment:7 Changed 4 years ago by Artur Delura

Ah, I ommited this accidentially :(

comment:8 Changed 4 years ago by Artur Delura

Status: review_failedassigned

comment:9 Changed 4 years ago by Artur Delura

Status: assignedreview

Changes in branch:t/11856.

comment:10 Changed 4 years ago by Piotr Jasiun

Status: reviewreview_failed
  • tests/adapters/jquery/manual/no-ckeditor fail.

Expected: CKEditor core should be loaded before jQuery adapter

Actual: jQuery should be loaded before CKEditor adapter. Have you mistaken loaded scripts order?

Both manual tests show the same error message.

comment:11 Changed 4 years ago by Piotrek Koszuliński

And no-ckeditor is not the right file name in CKE4 (unfortunately :D).

comment:12 Changed 4 years ago by Artur Delura

Status: review_failedassigned

comment:13 Changed 4 years ago by Artur Delura

Status: assignedreview

Changes in branch:t/11856.

comment:14 Changed 4 years ago by Piotr Jasiun

Resolution: fixed
Status: reviewclosed

Now everything is fine. Closed git:0a6108f.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy