Opened 10 years ago
Closed 10 years ago
#11856 closed Task (fixed)
jQuery adapter should thrown an issue if CKEditor or jQuery are not loaded
| Reported by: | Piotrek Koszuliński | Owned by: | Artur Delura |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
| Component: | General | Version: | 4.1 |
| Keywords: | Cc: |
Description (last modified by )
Now we silently fail when jQ is not loaded and throw meaningless error if CKEditor is not loaded. It would be worth being more communicative, but that means changing logic a little bit (in case of missing jQ), so this change should not be shipped in minor release.
Change History (14)
comment:1 Changed 10 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 10 years ago by
comment:3 Changed 10 years ago by
| Description: | modified (diff) |
|---|
comment:4 Changed 10 years ago by
| Owner: | set to Artur Delura |
|---|---|
| Status: | confirmed → assigned |
comment:6 Changed 10 years ago by
| Status: | review → review_failed |
|---|
You created very good message if jQuery is missing, but missing CKEDITOR is not handled at all.
comment:8 Changed 10 years ago by
| Status: | review_failed → assigned |
|---|
comment:10 Changed 10 years ago by
| Status: | review → review_failed |
|---|
tests/adapters/jquery/manual/no-ckeditorfail.
Expected: CKEditor core should be loaded before jQuery adapter
Actual: jQuery should be loaded before CKEditor adapter. Have you mistaken loaded scripts order?
Both manual tests show the same error message.
comment:11 Changed 10 years ago by
And no-ckeditor is not the right file name in CKE4 (unfortunately :D).
comment:12 Changed 10 years ago by
| Status: | review_failed → assigned |
|---|
comment:14 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Now everything is fine. Closed git:0a6108f.
Note: See
TracTickets for help on using
tickets.
cc