Opened 12 years ago
Closed 11 years ago
#11905 closed Bug (fixed)
editor#resize event should pass dimensions in data
| Reported by: | Olek Nowodziński | Owned by: | Artur Delura |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
At the moment, there's no simple way to save editor dimensions (those passed to editor.resize()) when user resizes the editor. It also means that there's no way to restore them, i.e. if user re-visits the page.
Following the question on SO.
Change History (10)
comment:1 Changed 12 years ago by
| Milestone: | → CKEditor 4.5.0 |
|---|---|
| Status: | new → confirmed |
comment:2 Changed 11 years ago by
| Owner: | set to Artur Delura |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:4 follow-up: 5 Changed 11 years ago by
| Status: | review → review_failed |
|---|
- you commented out two assertions: https://github.com/cksource/ckeditor-dev/blob/9a795fbfb37388a2dbcb8a126854d6b9ee25ea9a/tests/plugins/maximize/maximize.js#L61-L70 they should be removed or used,
- please prepare manual test which allows to resize, delete and recreate editor to check if recreated editor has the same height as deleted.
- properties you added to the documentation need descriptions: https://github.com/cksource/ckeditor-dev/commit/7d70614b69482b112a44f3f2833f82ba86846e2b
comment:5 Changed 11 years ago by
Replying to pjasiun:
- you commented out two assertions: https://github.com/cksource/ckeditor-dev/blob/9a795fbfb37388a2dbcb8a126854d6b9ee25ea9a/tests/plugins/maximize/maximize.js#L61-L70 they should be removed or used,
I commented them because they fails, they are new ones. I reported ticket:12357 for them as well. I don't see nothing wrong here. But instead of adding commented assersions I could also create a ticket branch #12357 and put them there.
comment:7 follow-up: 8 Changed 11 years ago by
| Status: | review → review_failed |
|---|
Finishbutton in the manual test does not work, because1.jsfile does not containbender.testmethod. If manual test containstestName.jsfile it is the automatic part of the test which will be run when manual part of the test is done (this is why manual test withtestName.jshasFinishbutton instead ofPass). If you just want to execute some javascript in your tests put it in theHTMLfile or create_assetsfolder.- do not use
localStoragein your test, every test should be independent, use variable instead, - move manual test to the resize plugin folder.
comment:8 Changed 11 years ago by
| Status: | review_failed → review |
|---|
Done everything. Changes and tests in branch:t/11905.
comment:9 Changed 11 years ago by
I pushed 2 small changed to tests and majorized branch, git:6cdf588.
comment:10 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |

Changes and tests in branch:t/11905. Also reported #12357.
Use cases: