Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1193 closed Bug (fixed)

Error loading sample10 in non-IE browsers

Reported by: Alfonso Martínez de Lizarrondo Owned by:
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: Core : Styles Version: SVN (FCKeditor) - Retired
Keywords: Cc:

Description

It gives an error

FCK.EditorWindow has no properties
http://localhost/fckdev/editor/_source/internals/fckselection_gecko.js
Line 120

GetBoundaryParentElement(true)fckselection_geck... (line 120)
RefreshActiveItems(Object FieldWidth=100 PanelWidth=150 PanelMaxHeight=150)fcktoolbarstyleco... (line 94)
RefreshState()fcktoolbarspecial... (line 96)
RefreshItemsState(Object Name=FCKeditor_1 Status=0 EditMode=0 HasFocus=false)fcktoolbarset.js (line 373)
FireEvent("OnSelectionChange", undefined)fckevents.js (line 52)
SaveUndoStep()fckundo.js (line 154)
OnAfterSetHTML()fck.js (line 271)
_FCK_EditingArea_OnLoad()fck.js (line 847)
(no name)()

Change History (5)

comment:1 Changed 12 years ago by Alfonso Martínez de Lizarrondo

Component: GeneralCore : Styles
Summary: Error loading sample10 in FirefoxError loading sample10 in non-IE browsers

All Firefox, Opera and Safari are affected by this bug.

As seen in the call stack it happens in the Style combo.

Not sure if this is part of the same bug: the editor seems to work correctly, but the Style combo will update its value only for one of the instances (usually the second one) in non-IE.

comment:2 Changed 12 years ago by Martin Kou

Resolution: fixed
Status: newclosed

There are other command state updates that depend on the FCKSelection.GetBoundaryParentElement() function (e.g. the indent buttons) that are working well for both editor frames. So I guess the style combo bug should be due to something else.

I've fixed the JavaScript error by adding a simple check in [860], and it doesn't seem to produce any bad side effect. For the style combo bug, I'm opening another ticket for it.

comment:3 Changed 12 years ago by Frederico Caldeira Knabben

A partial fix for is has been introduced with [859]. It works now perfectly with IE.

With Firefox/Opera/Safari instead, the toolbar get disabled when opening the style combo for the second instance (sometimes for the first). So, more work is necessary there.

comment:4 Changed 12 years ago by Martin Kou

I've opened a new ticket for the style combo bug, in #1277.

comment:5 Changed 12 years ago by Frederico Caldeira Knabben

Ticket #1280 has been opened for the "toolbar get disabled" behavior.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy