Opened 3 years ago

Closed 3 years ago

#11945 closed Bug (fixed)

Forms plugin should not change core method

Reported by: Piotrek Koszuliński Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.4.2
Component: General Version:
Keywords: Cc:

Description

Forms changes element.prototype.hasAttribute. That should land in core, so it's covered with core tests.

Change History (5)

comment:1 Changed 3 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:2 Changed 3 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedassigned

comment:3 Changed 3 years ago by Piotr Jasiun

Status: assignedreview

I moved this code, added some tests and refactor hasAttribute, because it became messy.

Last edited 3 years ago by Piotr Jasiun (previous) (diff)

comment:4 Changed 3 years ago by Olek Nowodziński

Status: reviewreview_passed

Rebased branch on master. Pushed a commit with minor refactoring.

comment:5 Changed 3 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy