We are migrating CKEditor issue tracking to GitHub. Please, use GitHub to report any new issues.

The former tracking system (this website) will still be available in the read-only mode. All issues reported in the past will still be available publicly and can be referenced.

Important: we decided not to transfer all the tickets to GitHub, as many of them are not reproducible anymore or simply no longer requested by the community.
If the issue you are interested in, can be still reproduced in the latest version of CKEditor, feel free to report it again on GitHub.
At the same time please note that issues reported on this website are still taken into consideration when picking up candidates for next milestones.

To report a new issue, go to https://github.com/ckeditor/ckeditor-dev/issues and follow the instructions in the issue template.

Context Navigation

← Previous Ticket
Next Ticket →

Opened 11 years ago

Closed 11 years ago

#11945 closed Bug (fixed)

Forms plugin should not change core method

Reported by:	Piotrek Koszuliński	Owned by:	Piotr Jasiun
Priority:	Normal	Milestone:	CKEditor 4.4.2
Component:	General	Version:
Keywords:		Cc:

Description

Forms changes element.prototype.hasAttribute. That should land in core, so it's covered with core tests.

Change History (5)

comment:1 Changed 11 years ago by Piotrek Koszuliński

Status:	new → confirmed

comment:2 Changed 11 years ago by Piotr Jasiun

Owner:	set to Piotr Jasiun
Status:	confirmed → assigned

comment:3 Changed 11 years ago by Piotr Jasiun

Status:	assigned → review

I moved this code, added some tests and refactor hasAttribute, because it became messy.

Last edited 11 years ago by Piotr Jasiun (previous) (diff)

comment:4 Changed 11 years ago by Olek Nowodziński

Status:	review → review_passed

Rebased branch on master. Pushed a commit with minor refactoring.

comment:5 Changed 11 years ago by Piotr Jasiun

Resolution:	→ fixed
Status:	review_passed → closed

git:6c83319

Note: See TracTickets for help on using tickets.

Download in other formats: