Opened 11 years ago
Closed 11 years ago
#11947 closed Bug (fixed)
[FF IE11] Shift+Enter in lists produces two line breaks
| Reported by: | Karen Ananiev | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.2 |
| Component: | UI : Enter Key | Version: | 4.0 |
| Keywords: | Firefox IE11 | Cc: |
Description
Use the code:
<ul> <li><strong>test</strong></li> <li>test</li> </ul>
Press Shift+Enter at the end of the first line.
Expected: One line created
Actual: Two lines created
Change History (13)
comment:1 Changed 11 years ago by
| Status: | new → pending |
|---|
comment:2 Changed 11 years ago by
- Here is the screencast: http://www.screencast.com/t/YtE8fwlGD2l
- On ckeditor.com/demo as well as on nightly build
- FF 29.0
Please let me know if you need more details. Thank you!
comment:3 Changed 11 years ago by
| Component: | General → UI : Enter Key |
|---|---|
| Status: | pending → confirmed |
Ok, I can see it. It must be the very first click. If caret is placed at the end by end button or if I click in more than one place before, I cannot reproduce it.
comment:4 Changed 11 years ago by
| Keywords: | Firefox IE11 added |
|---|---|
| Summary: | [FF] Shift+Enter in lists produces two line breaks → [FF IE11] Shift+Enter in lists produces two line breaks |
| Version: | → 4.0 |
Problem can be reproduced from CKEditor 4.0 (works fine in beta). in IE11 and Firefox
comment:5 Changed 11 years ago by
I see that brs are inserted into strong tag and below the strong tag. I believe we had such issue with br tags being inserted into strong tag but I can't find it right now.
comment:6 Changed 11 years ago by
| Milestone: | → CKEditor 4.4.2 |
|---|---|
| Owner: | set to Piotrek Koszuliński |
| Status: | confirmed → assigned |
Hmm... that would mean that our element.getBogus method misses the <br> inserted inside <strong> by the browser. Or something similar. I have a feeling that this might be related to few other issues that we saw recently which happened at the end of line. Let's take a look at this - 4.4.2 it is.
comment:7 Changed 11 years ago by
I have found issue I was talking about #8958. This isn't the same case but as I remembered it concerns brs in strong :).
comment:8 Changed 11 years ago by
| Status: | assigned → review |
|---|
Pushed branch:t/11947. The bug was caused by enter key trying to append bogus to the wrong node. It did not consider a situation when line break is inserted into an inline element.
comment:9 Changed 11 years ago by
| Status: | review → review_failed |
|---|
4 red tests in IE 11, on the t/11947 branch: http://tests.ckeditor.dev:1030/tests/plugins/enter/enterkey
comment:11 Changed 11 years ago by
Oops! I forgot to mention that you must use benderjs-ckeditor/t/11947.
comment:12 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Now everything looks and works fine. I rebased branch on the top on the master.
comment:13 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on master with git:c6b36c2 in ckeditor-dev and 62c81e0 in benderjs-ckeditor.
I can't reproduce it.