Opened 11 years ago
Closed 11 years ago
#12000 closed Bug (fixed)
[Nested widgets] Widgets are not initialized inside nested editables
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.2 |
| Component: | UI : Widgets | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description (last modified by )
Part of #10931.
- On editor setData.
- On nested editable setData.
- On undo/redo.
- On paste (insertHtml in general).
Notes:
- initOnAll must enter nested editables.
- checkWidgets must be reviewed.
Change History (9)
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → confirmed |
comment:2 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
comment:4 Changed 11 years ago by
| Status: | assigned → review |
|---|
Pushed both branches. I needed to extract #12018 because it turned out to be a separate big topic. So this ticket focuses on initialization, without garbage collecting and destroying.
comment:6 Changed 11 years ago by
| Status: | review → review_failed |
|---|
One of new test is failing on IE9 :(.
comment:7 Changed 11 years ago by
| Status: | review_failed → review |
|---|
Fortunately it was only a bug in the tests.
comment:8 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Pushed a single commit to test branch. Everything seems to be fine.
comment:9 Changed 11 years ago by
| Milestone: | → CKEditor 4.4.2 |
|---|---|
| Resolution: | → fixed |
| Status: | review_passed → closed |
Fixed on master with git:fd15d20 on dev and c0d3ae8 on tests.
Note: See
TracTickets for help on using
tickets.
I've implemented a set of basic integration tests for initializing nested widgets on setData, nestedEditable.setData, undo/redo and pasting. All except one pass after 1LOC fix which I pushed in branch:t/12000. Unfortunately, the one is rather strange and related to incorrect selection stored with snapshot in undo manager, which totally breaks undoing.