Opened 9 years ago
Closed 9 years ago
#12132 closed Bug (fixed)
Image is inserted with width&height styles even when they are not allowed
Reported by: | Jakub Ś | Owned by: | Artur Delura |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.4.3 |
Component: | General | Version: | 4.1 |
Keywords: | Cc: |
Description (last modified by )
- Use below setting:
var editor = CKEDITOR.replace( 'editor1', { disallowedContent : 'img{width, height}[width, height]' });
- try to insert a new image (plase be sure that provided url is valid and blur text input before closing dialog).
Removing width, height works great on initial content but it doesn't when you insert new image. Here is what happens:
- Image is inserted with width/height style (can be checked with firebug)
- When you switch to source mode style is still there. Method getData also returns width/height in style.
- Only second switch to source mode returns width/height from image. Could be applicable for other elements.
Change History (11)
comment:1 Changed 9 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
Summary: | It is not possible to remove width height from image with disallowedContent → Image is inserted with width&height styles even when they are not allowed |
---|---|
Version: | 4.4.0 → 4.1 |
I rephrased title and changed version, because this issue is caused by incomplete integration of ACF and image dialog.
PS. Image2 should be checked for the same scenario.
comment:4 Changed 9 years ago by
Milestone: | → CKEditor 4.4.3 |
---|
comment:5 Changed 9 years ago by
Description: | modified (diff) |
---|
comment:7 Changed 9 years ago by
Owner: | set to Artur Delura |
---|---|
Status: | confirmed → assigned |
comment:9 Changed 9 years ago by
Status: | review → review_passed |
---|
I rebased branch:t/12132 and pushed additional commits. New test wasn't checking the right image (after switch to inline editors) so it wasn't checking anything actually. Additionally, it's hard to tell whether image was really downloaded and height/width read. So I added an additional test with the same scenario but width and height allowed (it was actually missing).
comment:10 Changed 9 years ago by
You are right, I didn't want to set real dimensions, because I wanted to make test bulletproof but I went to far. But that are test - some things can be hardcoded.
comment:11 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed on master with git:731ec29.
This ticket was created based on #12126.