Image is inserted with width&height styles even when they are not allowed

[Jakub Ś]

1. Use below setting:

   var editor = CKEDITOR.replace( 'editor1', {	
   	disallowedContent : 'img{width, height}[width, height]'				
   });
   

2. try to insert a new image (plase be sure that provided url is valid and blur text input before closing dialog).

Removing width, height works great on initial content but it doesn't when you insert new image. Here is what happens:

1. Image is inserted with width/height style (can be checked with firebug)
2. When you switch to source mode style is still there. Method getData also returns width/height in style.
3. Only second switch to source mode returns width/height from image. Could be applicable for other elements.

[Jakub Ś]

This ticket was created based on #12126.

[Piotrek Koszuliński]

I rephrased title and changed version, because this issue is caused by incomplete integration of ACF and image dialog.

PS. Image2 should be checked for the same scenario.

[Olek Nowodziński]

cc

[Artur Delura]

Fixes and tests on ​branch:t/12132

[Piotrek Koszuliński]

I rebased ​branch:t/12132 and pushed additional commits. New test wasn't checking the right image (after switch to inline editors) so it wasn't checking anything actually. Additionally, it's hard to tell whether image was really downloaded and height/width read. So I added an additional test with the same scenario but width and height allowed (it was actually missing).

[Artur Delura]

You are right, I didn't want to set real dimensions, because I wanted to make test bulletproof but I went to far. But that are test - some things can be hardcoded.

[Piotrek Koszuliński]

Fixed on master with ​git:731ec29.