Changes between Initial Version and Version 1 of Ticket #12163, comment 8


Ignore:
Timestamp:
Sep 24, 2014, 3:03:22 PM (10 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12163, comment 8

    initial v1  
    11I reverted this change in git:df1293de.
    22
    3 I realised that it doesn't make sense, because enabling the sharedspace plugin will disable maximize and resize even though it may not be configured (config.sharedSpaces). That may break  websites which included the sharedspace but don't use it in some cases.
     3I realised that it doesn't make sense, because enabling the sharedspace plugin will disable the maximize and resize plugins even though the sharedspaces feature may not be truly enabled (it needs config.sharedSpaces). That may break  websites which included the sharedspace but don't use it in some cases.
    44
    55Additionally, I was reluctant to make this change from the beginning and now I'm strongly against it. One plugin cannot disable itself based on another's plugin configuration and existence. This will make too strong relations between our plugins and may be a cause of bugs in the future. Additionally, there are more incompatible plugins, like the bbcode, but we don't check in dozen of other plugins whether it's enabled. Instead, we properly configure the list of plugins which are enabled. This is the right way to resolve conflicts.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy