Opened 5 years ago

Last modified 5 years ago

#12191 assigned Task

Create tests and docs for node.getNextSourceNode and node.getPreviousSourceNode methods

Reported by: Marek Lewandowski Owned by: Marek Lewandowski
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description (last modified by Marek Lewandowski)

CKEDITOR.dom.node#getNextSourceNode
CKEDITOR.dom.node#getPreviousSourceNode

Seems that these methods are missing docs, and they are pretty useful and important. Additionally we should provide some test for them.

Change History (3)

comment:1 Changed 5 years ago by Marek Lewandowski

Description: modified (diff)
Owner: set to Marek Lewandowski
Status: newassigned

comment:2 Changed 5 years ago by Marek Lewandowski

I've created major portion of tests in git:66fe5e6135461. It shown that getPreviousSourceNode() does not work correctly.

Together with Piotr Koszulinski we decided we'll attempt to fix the function and see how much tests will fail after this change.

I created an umptomized fix for it, and FF reports 90 failed tests. Failed tests are spread among multiple TestSuites so they might touch diffrent places. Later on I'll check if it's easy to fix.

Preview pushed to t/12191 at dev.

comment:3 Changed 5 years ago by Piotrek Koszuliński

cc

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy