Changes between Version 2 and Version 3 of Ticket #12341


Ignore:
Timestamp:
Aug 21, 2014, 3:21:26 PM (11 years ago)
Author:
Piotr Jasiun
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12341 – Description

    v2 v3  
    22Related to #12173.
    33
     4* On `editable#cut` content should be deleted with lower priority (999). Currently it's hard to override cut data, because it's immediately gone.
     5* `initPasteDataTransfer` has no documentation.
     6* In `initPasteDataTransfer` and `initDropDataTransfer` you expect first argument to be what? Because docs says it's native event, when it's not.
     7* I mentioned this during one of previous reviews and I noticed this again - we can't write conditional code based on repeating `CKEDITOR.env.ie` usage. This makes code hard to read and hard to maintain, because it's unclear what this condition means - why IE, why not other browsers, whether IE12, 13 too or not. You need to create meaningfull variables like `dataTransferSetCustomDataSupport` and use them. E.g. in `pasteDataFromClipboard` you created `htmlAlwaysInDataTransfer` - it's great, just make it global for this plugin and then create more of them.
     8* `CKEDITOR.DATA_TRANSFER_INTERNAL` flags should start from 1 (1, 2, 4).
    49
    510TC1 (Chrome,FF):
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy