Opened 10 years ago
Last modified 10 years ago
#12341 closed Bug
Fixes after #12173 review. — at Version 3
Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
Component: | General | Version: | |
Keywords: | Cc: |
Description (last modified by )
Part of #11437. Related to #12173.
- On
editable#cut
content should be deleted with lower priority (999). Currently it's hard to override cut data, because it's immediately gone. initPasteDataTransfer
has no documentation.- In
initPasteDataTransfer
andinitDropDataTransfer
you expect first argument to be what? Because docs says it's native event, when it's not. - I mentioned this during one of previous reviews and I noticed this again - we can't write conditional code based on repeating
CKEDITOR.env.ie
usage. This makes code hard to read and hard to maintain, because it's unclear what this condition means - why IE, why not other browsers, whether IE12, 13 too or not. You need to create meaningfull variables likedataTransferSetCustomDataSupport
and use them. E.g. inpasteDataFromClipboard
you createdhtmlAlwaysInDataTransfer
- it's great, just make it global for this plugin and then create more of them. CKEDITOR.DATA_TRANSFER_INTERNAL
flags should start from 1 (1, 2, 4).
TC1 (Chrome,FF):
- open http://ckeditor.dev/plugins/clipboard/dev/dnd.html
- copy text from textarea
- try pasting it into first editor
- nothing happens
TC2 (IE8):
- open http://ckeditor.dev/plugins/clipboard/dev/dnd.html
- copy text from textarea
- paste it... it's underlined :D
- it happens only when pasting into the framed editor and it happens also when pasting using button in the toolbar (and allowing clipboard access)
- and that happens because our pastebin doesn't grab data at all, but
editor#paste
is fired so... we access clipboard directly :|
Change History (3)
comment:1 Changed 10 years ago by
Owner: | set to Piotr Jasiun |
---|---|
Status: | new → assigned |
comment:2 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 10 years ago by
Description: | modified (diff) |
---|