Missing null check in the pagebreak plugin

[(David *)Frenkiel]

Line 137 in plugins/pagebreak/plugin.js: <code>return parent && parent.name == 'div' && parent.styles[ 'page-break-after' ]; </code>

I've come across content in which parent.styles was undefined, resulting in the parser process crashing and further plugins not being loaded. I'll try to add a screenshot, if the system here permits it.

[(David *)Frenkiel]

Screenshot from devtools

[Piotrek Koszuliński]

The styles property should not be null during data filtering. So the bug is somewhere in ACF or in the way how it's used. Could you provide more details (a working sample preferably) which will let us reproduce this error?

[(David *)Frenkiel]

sure, try here: ​http://www.loopindex.com/lite/spanbug/?v=dev

open in chrome.

1. wait for the page to load.
2. open dev tools
3. type the letter 'a' before the word 'delete'. It should have a light blue bg.
4. switch to source mode
5. switch to wysiwyg mode
6. boom

[Piotrek Koszuliński]

OK, I understood the issue. You have spans directly in the editable because auto paragraphing is disabled. We access span.parent which gives us a the editable, but since this element is not passed through filter it does not have the style property. You're right that check must be added.

[Artur Delura]

Changes and tests in ​branch:t/12411.

[Piotrek Koszuliński]

Perfect. Fixed on master with ​git:6daae25.