Opened 4 years ago

Last modified 4 years ago

#12419 confirmed Bug

Not possible to change title for Table in Text and Table Template

Reported by: Satya Minnekanti Owned by:
Priority: Normal Milestone:
Component: General Version: 3.6.1
Keywords: IBM Cc: Irina

Description (last modified by Jakub Ś)

To reproduce the defect:

  1. Open any CK Sample, open Templates dialog and select Text and Table Template.
  1. Right click inside table cell, open Table Properties dialog by clicking on Table Properties option in context menu.
  1. Try to change Table Caption

Issue: Caption field is disabled, we should allow the user to change Table Caption

Edit:

As mentioned in comment:5, the fix for #6663 which is "enabled field for text only caption" might not have been correct because as @satya has mentioned it this is AVT violation because keyboard user cannot modify Table Caption.

Field should be enabled but it is not yet clear how HTML in dialog should be presented.

Change History (7)

comment:1 Changed 4 years ago by Jakub Ś

Status: newpending

This is happening because in template, text in caption is wrapped in strong tag.

This problem can be reproduced from CKEditor 3.6.1 rev. [6956] in every browser.

Another way to reproduce:

  1. Create table with caption
  2. Check table properties -> Caption is enabled
  3. Select text in caption and bold it
  4. Check table properties -> Caption is disabled

@satya this has started occurring after fixing bug you have reported #6663. I assume you have confirmed that you are satisfied with that solution. Could you confirm that you want to have it changed now?

comment:2 in reply to:  1 Changed 4 years ago by Satya Minnekanti

Replying to j.swiderski:

This is happening because in template, text in caption is wrapped in strong tag.

This problem can be reproduced from CKEditor 3.6.1 rev. [6956] in every browser.

Another way to reproduce:

  1. Create table with caption
  2. Check table properties -> Caption is enabled
  3. Select text in caption and bold it
  4. Check table properties -> Caption is disabled

@satya this has started occurring after fixing bug you have reported #6663. I assume you have confirmed that you are satisfied with that solution. Could you confirm that you want to have it changed now?

@j.swidrski thanks for the reply, but i think it has nothing to do with #6663 & also fix for defects #7944 & #7945 that were mentioned in #6663 is not working any more when i press enter in a table caption it's creating paragraphs instead of arrow keys & also i can insert Horizontal line inside a Table Caption. Do you want me to re-open them?

comment:3 Changed 4 years ago by Jakub Ś

@j.swidrski thanks for the reply, but i think it has nothing to do with #6663

It does because this is the revision where caption shows up as disabled in table properties dialog

you want me to re-open them?

Please, let us check these issues first.

comment:4 Changed 4 years ago by Jakub Ś

@satya I have checked all issues you have mentioned and I think this report is invalid or you are asking for a feature in which field for caption will show HTML to edit.

  1. It has been agreed in #6663 ticket that dialog field caption will be disabled if it contains HTML. Please see: http://dev.ckeditor.com/ticket/6663#comment:7
  1. Yes it is true that HR's and P's are inserted in table caption but this is because CKEditor 4 is adjusted to HTML5 and in HTML5 the caption element allows flow content (former block and inline). Please see: http://www.w3.org/TR/html-markup/caption.html#caption.

I think the most important thing for point 2 is that no JS error is thrown. As for paragraphs and horizontal lines or even tables, they are all allowed in caption element in HTML5.


The only "issue" I see here is feature request to extend table dialog to show HTML but I'm not really sure if this is the best idea.

comment:5 in reply to:  4 Changed 4 years ago by Satya Minnekanti

Replying to j.swiderski:

@satya I have checked all issues you have mentioned and I think this report is invalid or you are asking for a feature in which field for caption will show HTML to edit.

  1. It has been agreed in #6663 ticket that dialog field caption will be disabled if it contains HTML. Please see: http://dev.ckeditor.com/ticket/6663#comment:7
  1. Yes it is true that HR's and P's are inserted in table caption but this is because CKEditor 4 is adjusted to HTML5 and in HTML5 the caption element allows flow content (former block and inline). Please see: http://www.w3.org/TR/html-markup/caption.html#caption.

I think the most important thing for point 2 is that no JS error is thrown. As for paragraphs and horizontal lines or even tables, they are all allowed in caption element in HTML5.


The only "issue" I see here is feature request to extend table dialog to show HTML but I'm not really sure if this is the best idea.

@j.swiderski Thanks for the reply. I agree with your explanation of P's instead of br's in Table Caption. i have checked http://dev.ckeditor.com/ticket/6663#comment:7 but it's saying it has the patch to allow caption field to be enabled.. this is the comment

The dialog must still maintain the caption editable. It's a valuable feature we don't want to loose.6663.patch was implemented exactly in this way (enabled field for text only caption), can do check it again?

If we don't enable this it's an AVT violation because keyboard user can not modify Table Caption.

comment:6 Changed 4 years ago by Jakub Ś

I think there was some misunderstanding between Fred and Garry:)

The way I understand it:
Fred says that dialog must be enabled
while Garry says that field will be enabled for text only caption which should be understood as non-HTML.


If we don't enable this it's an AVT violation because keyboard user can not modify Table Caption.

I that case I will edit this bug and confirm it.

comment:7 Changed 4 years ago by Jakub Ś

Description: modified (diff)
Status: pendingconfirmed
Version: 3.6.1
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy