Can't update checkbox/radio button state with dialog when it is opened with double-click

[Jakub Ś]

In Blink and Webkit it is impossible to change state of checkboxes/radiobuttons with properties dialog when this dialog is opened with double-click.

To reproduce:

1. Open checkbox/radio button properties dialog.
2. Enter all the values and press OK.
3. Double-click on checkbox/radio button to open the checkbox/radio button properties dialog again.
4. Click on checkbox in ckeckbox/radio button properties dialog to make it unselected and press OK.

Result: the state of checkbox/radio button is not changed (if it was checked, it is still checked).

Problem can be reproduced from CKEditor 3.3 (when opening properties dialog with double-click was made possible) in Blink and Webkit browsers.

NOTE: When you right-click on checkbox/radio button to open dialog and change its state then it works.

[Jakub Ś]

#13072 was marked as duplicate.

[Tomasz Jakut]

It seems that the bug is caused only by the double-click made by user - doing it programmatically doesn't raise an error. The fix was simple: checked property, not only attribute, should be changed. Pushed ​branch:t/12465.

[kkrzton]

If the fix is only for Blink/Webkit, probably CKEDITOR.env.webkit could be used so it is only applied on those browsers? There is already bender.ignore() in manual test, so the ###ONLY IN BLINK/WEBKIT### information is not necessary IMHO.

Apart from these tiny details above, everything looks good.

[Tomasz Jakut]

Pushed fixes for tests and checking for WebKit to ​branch:t/12465.

[Tade0]

Nothing broke due to this change, LGTM.

Fixed with ​git:b6612e607f32a3b6b2c94975fd7ec05da6d9be0e.