Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12501 closed Bug (fixed)

rulePattern does not allow custom elements like <custom-tag>

Reported by: Leon Machens Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.4.6
Component: General Version: 4.1
Keywords: Cc:

Description

Custom elements are described here. Due to the rulePattern in filter.js it is not possible to use elements with a minus-character.

A simple solution is to edit the pattern to:

var rulePattern = /^([a-z0-9-*\s]+) ...

Change History (4)

comment:1 Changed 4 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned
Version: 4.4.44.1

I remember that there was some problem when parsing ACRs if - was allowed, but let's see this again. Note that to avoid unnecessary complexity of ACRs string format and its parser we implemented more powerful object format and it accepts dashes. So if there will be some problem, we are not going to change the parser.

comment:2 Changed 4 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.4.6
Resolution: fixed
Status: assignedclosed

Ok, I didn't see any problems now. Fixed on master with git:3574029.

comment:3 Changed 4 years ago by Leon Machens

Thank you, can you fix it on major too?

comment:4 Changed 4 years ago by Piotrek Koszuliński

I merged master to major, so it's fixed there now too.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy