Opened 4 years ago

Closed 4 years ago

#12546 closed Bug (fixed)

Preview tab in docprops dialog is always disabled

Reported by: jhub Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.4.6
Component: General Version: 4.3
Keywords: Cc:

Description

This can easily be reproduced on the demo page:

http://ckeditor.com/demo#full-page

Click the docprops icon and you'll see that the preview tab is disabled.

I think that the problem is caused by the code in /plugins/dialog/plugins.js, lines 841ff. This code disables all tabs that do not contain an enabled input element. And the preview tab does not have such an element.

Change History (5)

comment:1 Changed 4 years ago by Piotrek Koszuliński

Keywords: docprops removed
Status: newconfirmed
Version: 4.4.54.3

comment:2 Changed 4 years ago by Jakub Ś

Thanks @Rainmar I was just confirming it :|

comment:3 Changed 4 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

comment:4 Changed 4 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.4.6
Status: assignedreview

It turned out that /plugins/dialog/plugins.jsL841 wasn't a problem. I committed tests in git:6322d11 which check this.

I also pushed branch:t/12546 which fixes the preview. I already wasted enough time for this plugin, so this time without tests.

comment:5 Changed 4 years ago by Piotr Jasiun

Resolution: fixed
Status: reviewclosed

I have added simple test, rebased and masterized this ticket. Closed with git:6e948c2.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy