Opened 9 years ago

Closed 8 years ago

#12733 closed Bug (fixed)

Radio button onChange doesn't work in IE9+

Reported by: i.kostadinov Owned by: Szymon Kupś
Priority: Normal Milestone: CKEditor 4.5.4
Component: UI : Dialogs Version: 4.0
Keywords: Cc:


I have defined a custom onChange function for a radio button group that I use in one of my custom dialogs. It works in Firefox, Chrome and IE8 (haven't tested earlier versions), but not in IE9, IE10 or IE11.

I think this is because of the IE changes described here -

I think the browser check should be the same as for the checkbox, namely

if ( ! || ( CKEDITOR.env.version > 8 ) )

instead of

if ( ! )

Change History (3)

comment:1 Changed 9 years ago by Jakub Ś

Status: newconfirmed

Code you mention is located in ckeditor/plugins/dialogui/plugin.js in checkbox and radio prototypes.

Now, I have added your changes to this plugin code and below code to replacebycode.html sample

CKEDITOR.on( 'dialogDefinition', function( ev ) {
		var dialogName =,
			dialogDefinition =,
			editor = ev.editor;
		if ( dialogName == 'image' ) {			
			// Get a reference to the "Image Upload" tab.
			var infoTab = dialogDefinition.getContents( 'info' );					
			infoTab.add( {
				type: 'radio',
				id: 'customId',
				label: 'Test Label',
				title: 'Test Title',
				className: 'radioClass',
				required: false,
				items: [
					['Test0', 'Test0', 'Test0'],
					['Test1', 'Test1', 'Test1'],
					['Test2', 'Test2', 'Test2']
				onChange: function( event ){

It has worked thus I think you are 100% right.

comment:2 Changed 8 years ago by Szymon Kupś

Owner: set to Szymon Kupś
Status: confirmedreview

comment:3 Changed 8 years ago by Szymon Kupś

Milestone: CKEditor 4.5.4
Resolution: fixed
Status: reviewclosed

I've added some minor code style fixes and merged changes into master with git:47e6f7f.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy