Opened 4 years ago

Last modified 4 years ago

#12768 confirmed Bug

Suggested Modification to jQuery Adaptor to better support jQuery UI

Reported by: Steve James Owned by:
Priority: Normal Milestone:
Component: Documentation & Samples Version:
Keywords: Cc:

Description

When using jQuery UI, there are sometimes issues when CKEditor is instantiated inside a jQuery UI modal dialog. Typically, the CKEditor dialogs become read-only.

This is explained here: http://bugs.jqueryui.com/ticket/9087

It would be very helpful if jQuery UI was detected in the jQuery Adaptor (typeof jQuery.ui != 'undefined') and the fix for CKEditor instances in modal dialogs (from the above ticket reference) was executed in that case. I do not expect the JQuery UI developers to implement something specific for CKEditor, so I am hoping that you may be open to adding some variation of this in the jQuery adaptor.

Change History (3)

comment:1 Changed 4 years ago by Jakub Ś

Status: newconfirmed

This is what adapter should be used for so yes idea is very good.

JQuery Adapter could use code from http://bugs.jqueryui.com/ticket/9087#comment:30 (kudos to @kamelkev) and insert it into HTML page as shown in e.g. http://dev.ckeditor.com/attachment/ticket/10081/index2.html.

Such approach would allow us to finally close #10269.

comment:2 Changed 4 years ago by Jakub Ś

Component: GeneralDocumentation & Samples

I got to quick with this issue. After some discussion we have decided that we should put this solution into Documentation.

The jQuery Adapter is adapter for jQuery not jQuery UI thus we should keep it clean and don't mix solutions for various projects into one adapter.

comment:3 Changed 4 years ago by Steve James

Well, perhaps a jQuery UI adapter then? ;-) This has been a long standing issue. I do not view this so much as a bug as an area of incompatibility in an interface. There are a couple of caveats that I am concerned may not be adequately understood from a "documentation fix":

(1) I think the _allowInteraction hook provided in jQuery UI only works in jQUI 1.10 and above (not sure if that is the actual version they implemented it). There was a "fix" for other earlier versions that was provided in a patch. A documentation approach should cover both resolutions.

(2) I am not exactly thrilled with the _allowInteraction hook approach implemented in jQuery UI.
Reason: To my eyes, it looks like if there were two plug-ins independently using the hook, there could be the potential for the second plug-in to clobber the function defined by the first plug-in for _allowInteraction. A documentation approach should point out the potential for issues if more than one plug-in is independently using the _allowInteraction hook. I think that either all affected plug-ins that need interaction inside jQUI modal dialogs must be accounted for in the defined function for _allowInteraction, OR each plug-in independently using the hook must check if is already in use and preserve that functionality in addition to adding to it.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy