Opened 5 years ago

Closed 5 years ago

#12781 closed New Feature (fixed)

Support multiple editors creation in CKEditor bender plugin

Reported by: Piotr Jasiun Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.5.0 Beta
Component: General Version:
Keywords: Cc:

Description

It should be possible to create multiple editors in the single tests suit. Also init method should not be locked, if bender.editor property is used.

Change History (3)

comment:1 Changed 5 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: newassigned

comment:2 Changed 5 years ago by Piotr Jasiun

Milestone: CKEditor 4.5.0
Status: assignedreview

Changes:

  • if bender.editors is defined, multiple editors will be created and available the same way bender.editor works,
  • if bender.editorsConfig is defined, it will be merged with config of editors in bender.editors,
  • tests with bender.editor/bender.editors now can have init or async:init method,
  • setUpEditor method was removed and all tests which used that method were rewritten to bender.editors,
  • createTestsForEditors now need editor names instead of instanced as a first parameter.

I also created tests for the new features and run all tests on Chrome, Safari, IE11 and IE8. Everything seems to work fine.

comment:3 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Merged to major with git:af2b59d.

Please send an email to the team to notify them about the new options and to warn about merging from master to major.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy