Opened 5 years ago

Closed 5 years ago

#12935 closed Bug (fixed)

[Bender] Automatic tests start automatically in manual tests

Reported by: g.pabian Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.5.0 Beta
Component: General Version:
Keywords: Cc:

Description

There's an issue in the test execution flow that causes automatic tests that are mixed with manual tests to start automatically instead of waiting for the "Finish" button to be pressed.

Change History (6)

comment:1 Changed 5 years ago by g.pabian

I've modified the plugin to make use of the bender.defer() API and also updated benderjs-yui plugin in package.json to version 0.2.4. Changes in t/12935.

comment:2 Changed 5 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newreview

comment:3 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_passed

R+, but we'll wait with merging for Bender 0.2.2 because we need some commits from the Bender's master branch.

comment:4 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.5.0

Due to changes that we already made in major in the file which was touched by this commit to, we're unable to rebase it on master. Hence, we're going to fix this issue on 4.5.0 and not earlier.

comment:5 Changed 5 years ago by Piotrek Koszuliński

I rebased branch:t/12935 and pushed additional commit.

comment:6 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on major with git:339d419.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy