Opened 9 years ago
Closed 9 years ago
#12935 closed Bug (fixed)
[Bender] Automatic tests start automatically in manual tests
Reported by: | g.pabian | Owned by: | Piotrek Koszuliński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
Component: | General | Version: | |
Keywords: | Cc: |
Description
There's an issue in the test execution flow that causes automatic tests that are mixed with manual tests to start automatically instead of waiting for the "Finish" button to be pressed.
Change History (6)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Owner: | set to Piotrek Koszuliński |
---|---|
Status: | new → review |
comment:3 Changed 9 years ago by
Status: | review → review_passed |
---|
R+, but we'll wait with merging for Bender 0.2.2 because we need some commits from the Bender's master branch.
comment:4 Changed 9 years ago by
Milestone: | → CKEditor 4.5.0 |
---|
Due to changes that we already made in major in the file which was touched by this commit to, we're unable to rebase it on master. Hence, we're going to fix this issue on 4.5.0 and not earlier.
comment:6 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed on major with git:339d419.
I've modified the plugin to make use of the bender.defer() API and also updated benderjs-yui plugin in package.json to version 0.2.4. Changes in t/12935.