Opened 4 years ago

Closed 4 years ago

#12944 closed Bug (expired)

Webkit Blink regression: CKEditior initial state not set upon load

Reported by: Irina Owned by:
Priority: Normal Milestone:
Component: General Version: 4.4.6
Keywords: IBM Webkit Blink Cc: Satya Minnekanti


Since version 4.4.6 the initial state of the editor isn't set when the page is loaded.

To reproduce:

1.Open tabindex.html sample in Chrome

2.Inspect the path bar

Problem: 'body' in the lower left do not appear until you click in the editor.

This is reproducible since 3048943550530ba2f48b43ce48939184118b34dd commit.

Note: works as expected in Firefox.

Change History (6)

comment:1 Changed 4 years ago by Jakub Ś

Keywords: Webkit Blink added
Status: newconfirmed
Summary: Webkit regression: CKEditior initial state not set upon loadWebkit Blink regression: CKEditior initial state not set upon load

This "regression" can be reproduced from CKEditor 4.4.6 in Blink and Webkit browsers.

It works fine in Firefox and has never worked in IE.

I agree that behaviour was changed but to me this is just a small and hardly visible change. Could you tell us what problem does it cause for you?

comment:2 Changed 4 years ago by Irina

One of the products sets the value for the font and the font size when the ckeditor is created. Because of this change, the values are not displayed now until you click in the ckeditor. It is also creating issues for automation testing since entering text via Selenium no longer works until you physically click inside the editor.

comment:3 Changed 4 years ago by Jakub Ś

Thank you. In my personal opinion such explanation is more than enough to justify why fix it or undo it.

comment:4 Changed 4 years ago by Piotrek Koszuliński

Status: confirmedpending

I believe we discussed this change in some other ticket already. This was a very important cleanup which fixed many bugs by simplifying the code.

There's no rule saying that a selection must be set in editor before it's even focused and used for the first time. It's the opposite – it's natural that user creates this first initial selection. This can be done in two ways – by clicking or by focusing the editor. And this is exactly what CKEditor does right now – if there's no selection on initial focus it sets the selection in a first editable location.

You mentioned that some tests with Selenium does not work. Question is – are the tests correct and/or is the Selenium behaviour realistic? If the same issue is reproducible manually, then I would certainly confirm such ticket. But if only tests fail, then it is something wrong with the tests or that Selenium does not reproduce a TC as a real user would do. (Actually, we've got a pretty bad experience with Selenium, so that's why I'm mentioning this).

I'm "deconfirming" this ticket.

comment:5 Changed 4 years ago by Jakub Ś

Extra question - would editor.focus()solve your issues? I think it should solve test problems, I'm not sure however about web page where it may not be desired to focus editor as the first component.

comment:6 Changed 4 years ago by Piotrek Koszuliński

Resolution: expired
Status: pendingclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy