Changes between Version 1 and Version 3 of Ticket #12955


Ignore:
Timestamp:
Feb 20, 2015, 8:39:10 AM (6 years ago)
Author:
Piotr Jasiun
Comment:

I think that using redundant data is a bad smell. Is there any reason to store _totalWeights in the separate variable, not counting it every time based on _tasks? Such variables may be introduce to fix some performance issue, but it should be added when the fragment of code met performance problem, not before, "just in case". Otherwise we can have bugs like this.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12955

    • Property Status changed from new to confirmed
  • Ticket #12955 – Description

    v1 v3  
    11Total weight is not updated when task is canceled. I pushed a [https://github.com/cksource/ckeditor-dev/commit/ae14678e6193f6b7fbb6d2a212022fe0bdb84374 tests] which show the problem.
     2
© 2003 – 2021 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy