Opened 10 years ago
Last modified 10 years ago
#12955 closed Bug
[Notification Aggregator] Total weight is not updated when task is canceled — at Version 3
| Reported by: | Piotr Jasiun | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
| Component: | General | Version: | 4.5.0 Beta |
| Keywords: | Cc: |
Description (last modified by )
Total weight is not updated when task is canceled. I pushed a tests which show the problem.
Change History (3)
comment:1 Changed 10 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | [Notification Aggregator] total weight is not updated when task is canceled → [Notification Aggregator] Total weight is not updated when task is canceled |
comment:2 Changed 10 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 10 years ago by
| Description: | modified (diff) |
|---|
Note: See
TracTickets for help on using
tickets.
I think that using redundant data is a bad smell. Is there any reason to store
_totalWeightsin the separate variable, not counting it every time based on_tasks? Such variables may be introduce to fix some performance issue, but it should be added when the fragment of code met performance problem, not before, "just in case". Otherwise we can have bugs like this.