Dropping image on image in editor causes page reload

[Jakub Ś]

Try dropping image on image in editor and page will relaod

[Piotrek Koszuliński]

I can only reproduce this with the image2 plugin, not with the image one.

See e.g.:

• ​http://tests.ckeditor.dev:1030/tests/plugins/uploadwidget/manual/image2 - reproducible
• ​http://tests.ckeditor.dev:1030/tests/plugins/uploadwidget/manual/image - not reproducible

[Artur Delura]

The problem was caused because drop event is not fired on contenteditable=false which is case on image2 plugin.

To make this happend - default browser action has been prevented in dragover event callback on widget wrapper element.

The curious fact is that such event is fired in Firefox.

Remaining problem is that now browser page is not reloaded, but image is uploaded nowhere.

[Artur Delura]

In the following situation we have to options. One is to prevent totally uploading images if drop is on elment which is cE=false or descendant.

The second solution is to move drop range right after first not editable boundary element.

Both options will be called, when drop target is noneditable.

[Piotrek Koszuliński]

In the following situation we have to options. One is to prevent totally uploading images if drop is on elment which is cE=false or descendant.

Drop on a non-editable element should be cancelled. I consider such drop as invalid.

The curious fact is that such event is fired in Firefox.

What's curious about the fact that such event is fired on Firefox? Or did you mean that it isn't fired?

Did you check whether dropping inside nested editable still works when dragover is cancelled on widget wrapper?

[Artur Delura]

Drop on a non-editable element should be cancelled. I consider such drop as invalid.

I implemented this that way, but now it is inconsistent with image plugin.

What's curious about the fact that such event is fired on Firefox? Or did you mean that it isn't fired?

Sorry, I meant that it's funny that it works only on FF. I didn't checked specification, but it seems logical there.

Did you check whether dropping inside nested editable still works when dragover is cancelled on widget wrapper?

I checked image2 with caption and dragging and droping text works properly there.

Changes in ​branch:t/13015.

[Piotrek Koszuliński]

Fixed on major with ​git:cb5fd3a.