Opened 4 years ago

Closed 4 years ago

#13032 closed Bug (fixed)

When upload is done notification update should be marked as important.

Reported by: Piotr Jasiun Owned by: Artur Delura
Priority: Normal Milestone: CKEditor 4.5.0
Component: General Version: 4.5.0 Beta
Keywords: Cc:

Description

Because of UX and accessibility the update when upload is done should be marked as 'important' (this is why 'important' flag was created).

Scenario:

  1. Open http://tests.ckeditor.dev:1030/tests/plugins/uploadwidget/manual/image
  2. Drop file so upload starts.
  3. Close the notification before upload is done.

Expected behavior: When upload is done and notification changes its type to success it should be shown again.

Actual behavior: It is not.

Change History (9)

comment:1 Changed 4 years ago by Piotr Jasiun

Fix in the t/13032 branch. Test is missing.

comment:2 Changed 4 years ago by Jakub Ś

Status: newconfirmed
Version: 4.5.0 (GitHub - major)

comment:3 Changed 4 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.5.0 BetaCKEditor 4.5.0

comment:4 Changed 4 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:5 Changed 4 years ago by Artur Delura

Status: assignedreview

Missed tests are in the same branch:t/13032.

comment:6 Changed 4 years ago by Piotrek Koszuliński

Status: reviewreview_failed

The test does not fail on major.

comment:7 Changed 4 years ago by Artur Delura

Status: review_failedreview

Are you sure? I rebased this branch to start from present major and reordered commits to make the test appear first. Here is the link to the appropriate test. Changes in the same branch:t/13032.

comment:8 Changed 4 years ago by Piotrek Koszuliński

To check whether the test fail on major/master I simply check out plugins/ and core/ to master/major. So the order of commits does not make any difference. But I'll check again. Maybe some cache issue.

comment:9 Changed 4 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Ok, the test indeed fails on major.

Merged to major with git:69c6724.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy