Ugly notification when response has HTML content

[Maciej]

Error occurs when response from imageUploadUrl link returns HTML content, ie PHP server returns stack trace.

Steps to reproduce:

1. Configure server to return stack trace for url set in imageUploadUrl
2. Use drag and drop to upload image
3. Observe ugly notification that overlaps page & editor

[Tade0]

Changes and tests in ​branch:t/13080.

Not sure about the test. It works, but it doesn't look clean. Any suggestions how to fix this?

[Piotr Jasiun]

You can not do data.message = responseError.replace( ': %1', '.' ); because you do not know what the responseError string will be in each language.

And about ​checking the `content-type` it is over-complication in my opinion. The whole code is in the fileUploadResponse listener so if someone want to have better error messages he can create his own fileUploadResponse listener. The default listener should be as simple as possible so developers we be able to create their own listeners based on this code.

[Piotr Jasiun]

And for tests you could use ​sinonjs to mock editors methods.

[Piotrek Koszuliński]

Oops. We reviewed this simultaneously :D. This is what I wrote:

---

I would simplify this even further. We can always display "Incorrect server response." error. Nothing more.

There are two reasons:

1. I don't like the logic with replacing ": %1" with "." or message. What if in some language colon isn't used or sentence does not end with a dot?
2. Checking if response format is text/plain does not mean that we know that HTML isn't there. I mean here both XSS and some other failures because we put some weird things that were supposed to be plain text inside notification.

So, I would KISS. Notification is for user, on the console we can log the rest.

As for tests, I think they are ok. Small code style issues:

• ​https://github.com/cksource/ckeditor-dev/commit/0794c362c080ba2f9aecf48d1d4c5770d6251a0c#diff-4cc646bfce424b3d6ce0181e41147703R179. Space after "//" and dot are missing.
• ​https://github.com/cksource/ckeditor-dev/commit/0794c362c080ba2f9aecf48d1d4c5770d6251a0c#diff-4cc646bfce424b3d6ce0181e41147703R187. We usually add a blank line before blocks like this.

[Tade0]

Changes in ​git:a076149.

I moved the error message to the console.

[Piotrek Koszuliński]

​http://tests.ckeditor.dev:1030/tests/plugins/filetools/fileloader#tests%2Fplugins%2Ffiletools%2Ffileloader%20-%20test%20error%20incorrect%20response is failing on ​branch:t/13080.

[Tade0]

Modified the test so that it expects the behavior that's implemented.

Changes on ​branch:t/13080

[Piotrek Koszuliński]

Fixed on major with ​git:68643de.

I made small improvements - it's good to teardown a stub, so next tests are not affected.