Opened 10 years ago
Closed 10 years ago
#13103 closed Task (fixed)
[Bender] Update benderjs-ckeditor plugin to support Bender 0.2.3
Reported by: | g.pabian | Owned by: | Piotrek Koszuliński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.4.8 |
Component: | General | Version: | |
Keywords: | Cc: |
Description
Bender 0.2.3 introduces a fix in the test directive parsing mechanism that makes the current version of the plugin crash while trying to convert coma-separated lists of plugins to arrays.
The current plugin depends on a "buggy" output of test directive parser. For example, such directives:
/* bender-ckeditor-plugins: foo, bar */ /* bender-ckeditor-remove-plugins: baz, qux, quux */
should be converted to the following object:
{ ckeditor: { plugins: 'foo, bar', remove: { plugins: 'baz, qux, quux' } } }
while in Bender 0.2.2 they produce this:
{ ckeditor: { plugins: 'foo, bar', 'remove-plugins': 'foo, bar, baz' } }
which doesn't really make any sense.
Change History (4)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Milestone: | → CKEditor 4.5.0 |
---|---|
Status: | new → confirmed |
comment:3 Changed 10 years ago by
Owner: | changed from g.pabian to Piotrek Koszuliński |
---|---|
Status: | confirmed → review |
comment:4 Changed 10 years ago by
Milestone: | CKEditor 4.5.0 → CKEditor 4.4.8 |
---|---|
Resolution: | → fixed |
Status: | review → closed |
Type: | Bug → Task |
Merged to master with git:56ad8fc.
I created a fix for this issue - I simply added support for Bender >= 0.2.3 directives while keeping backwards compatibility with the output produced by older versions of Bender.
Ticket branch: t/13103