Opened 5 years ago

Last modified 5 years ago

#13141 confirmed Bug

[FF] It's not possible to DnD inline widget inside nested editable

Reported by: Piotrek Koszuliński Owned by:
Priority: Must have (possibly next milestone) Milestone:
Component: UI : Widgets Version: 4.5.0 Beta
Keywords: Cc:

Description

  1. Open http://ckeditor.dev/plugins/widget/dev/nestedwidgets.html
  2. Try dragging one of the placeholders.
  3. The drop caret is invisible inside nested editable. It is visible only when dragging over the outer editable.

It seemed to work fine on major some time ago.

Change History (10)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:2 Changed 5 years ago by Piotrek Koszuliński

It seemed to work fine on major some time ago.

Thus, it needs to be bisected.

comment:3 Changed 5 years ago by Piotrek Koszuliński

Priority: NormalHigh

comment:4 Changed 5 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:5 Changed 5 years ago by Olek Nowodziński

git:8c1b9a6b0ac3d is the first bad commit.

comment:6 Changed 5 years ago by Piotrek Koszuliński

Interesting :)

comment:7 Changed 5 years ago by Olek Nowodziński

But truth to tell, it's all about this line.

A comment related to this change: https://dev.ckeditor.com/ticket/12172#comment:10

Last edited 5 years ago by Olek Nowodziński (previous) (diff)

comment:8 Changed 5 years ago by Olek Nowodziński

First attempt:

  • branch:t/13141
  • Focus widget/editor on draghandler's mousedown, so before dragstart. It looks like FF got issues when messing with focus on dragstart thus unable to drop into nested editable.

comment:9 Changed 5 years ago by Olek Nowodziński

Component: GeneralUI : Widgets
Milestone: CKEditor 4.5.0
Owner: Olek Nowodziński deleted
Status: assignedconfirmed

Finally it tuned out that the best solution is to leave this ticket and wait for Firefox team to act. The solution (hack) in comment:8 breaks undo (an additional step with focused widget). Other possible regressions are also hard to predict and the code gets tricky. It's a sad trade–off between undo and DnD.

It's quite possible that a more general and bulletproof approach to DnD+focus would do the job, but it requires time and resources. Together with Reinmar, we made a decision to put this ticket aside (at least in 4.5).

comment:10 Changed 5 years ago by Piotrek Koszuliński

Two more things:

  • branch:t/13141 contains a patch that one could use if they more cared about DnD in nested editables on Firefox than about the regressions that it introduces.
  • We find support for DnD in nested editables less important than those regressions, because they affect every scenario. That's why we chose to not act.
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy