Opened 8 years ago
Closed 8 years ago
#13155 closed Bug (fixed)
[Lineutils, DnD] incorrenct left margin in manual tests
| Reported by: | Piotr Jasiun | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.8 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description (last modified by )
Because manual tests use left margin on the body element, lineutils have incorrect left margin.
To reproduce:
- Open: http://tests.ckeditor.dev:1030/tests/plugins/clipboard/manual/draganddrop
- drag block widget (image with caption).
Magicline looks good in manual tests.
Attachments (2)
Change History (22)
comment:1 Changed 8 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 8 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | Magicline and lineutils incorrenct left margin in manual tests → Lineutils incorrenct left margin in manual tests |
comment:3 Changed 8 years ago by
comment:5 Changed 8 years ago by
| Status: | new → confirmed |
|---|---|
| Summary: | Lineutils incorrenct left margin in manual tests → [Lineutils, DnD] incorrenct left margin in manual tests |
comment:6 Changed 8 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:8 Changed 8 years ago by
| Milestone: | CKEditor 4.5.0 |
|---|
I rebased this branch on master, because this is a bug fix that can go in 4.4.8. However, during tests on IEs I got many errors when moving mouse over the classic editor. See attached screenshots. (PS. I removed the milestone for now, because this isn't a regression and it should not block 4.5.0 or 4.4.8).
Changed 8 years ago by
| Attachment: | Screen Shot 2015-05-11 at 16.58.38.png added |
|---|
Changed 8 years ago by
| Attachment: | Screen Shot 2015-05-11 at 16.59.26.png added |
|---|
comment:9 Changed 8 years ago by
| Status: | review → review_failed |
|---|
comment:10 Changed 8 years ago by
Hm... I've just checked that these errors are not regressions caused by this patch. Could you anyway check that this isn't something caused by the manual test itself or something that we can quickly fix?
comment:12 Changed 8 years ago by
| Milestone: | → CKEditor 4.5.0 |
|---|---|
| Status: | review_failed → review |
Could you anyway check that this isn't something caused by the manual test itself or something that we can quickly fix?
Fixed. Also:
- Found out that the fix in this branch broke the line positioning when body has
position: static.- Fixed it.
- Added manual test for such case.
Re-attaching to 4.5.
comment:14 Changed 8 years ago by
comment:15 follow-up: 16 Changed 8 years ago by
I've easily rebased the branch on 4.4.8:
I rebased this branch on master, because this is a bug fix that can go in 4.4.8.
comment:16 Changed 8 years ago by
| Milestone: | CKEditor 4.5.0 → CKEditor 4.4.8 |
|---|
Replying to Reinmar:
I've easily rebased the branch on 4.4.8:
I rebased this branch on master, because this is a bug fix that can go in 4.4.8.
Alright. I'm cool with it then.
comment:18 follow-up: 19 Changed 8 years ago by
| Status: | review → review_failed |
|---|
Hm... I've just checked that these errors are not regressions caused by this patch. Could you anyway check that this isn't something caused by the manual test itself or something that we can quickly fix?
On IE8 I still see the same errors.
comment:19 Changed 8 years ago by
| Status: | review_failed → review |
|---|
Replying to Reinmar:
Hm... I've just checked that these errors are not regressions caused by this patch. Could you anyway check that this isn't something caused by the manual test itself or something that we can quickly fix?
On IE8 I still see the same errors.
Pushed a commit to rebased branch:t/13155 which fixes the issue.
comment:20 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fixed on master with git:4b039c3.
Related: #13156.