[Adv. toolbar conf] config.removeButtons is ignored

[Piotrek Koszuliński]

1. Build basic preset.
2. Open the adv toolbar configurator
3. See that in the toolbar there are no undo and redo buttons but there are in the source.
4. Switch to the basic configurator and see that it correctly disables those buttons.

[Artur Delura]

To reproduce this issue on dev version we need to update a ​config.js to

CKEDITOR.editorConfig = function( config ) {

	config.plugins =
		'floatingspace,' +
		'list,' +
		'link,' +
		'toolbar,' +
		'undo,' +
		'wysiwygarea';

	config.toolbarGroups = [
		{ name: 'clipboard',   groups: [ 'undo' ] },
		{ name: 'links' }
	];

	config.removeButtons = 'Undo,Redo,Anchor';
};

[Artur Delura]

Config listed above is translated to

CKEDITOR.editorConfig = function( config ) {
	config.toolbar = [
		{ name: 'clipboard', items: [ 'Undo', 'Redo' ] },
		{ name: 'links', items: [ 'Link', 'Unlink', 'Anchor' ] }
	];
	config.removeButtons = 'Undo,Redo,Anchor';
}

but do we really should handle removeButtons in adv toolbar configurator? I think we should end up with

CKEDITOR.editorConfig = function( config ) {
	config.toolbar = [
		{ name: 'links', items: [ 'Link', 'Unlink' ] }
	];
}

It's simpler and more logical - Why add things and remove them at once?

[Piotrek Koszuliński]

Yes, I've been thinking about removing these buttons which are listed in config.removeButtons in config.js from the config.toolbar table that you can see in the configurator.

[Artur Delura]

So one-liner fix in ​branch:t/13173b.

[Piotrek Koszuliński]

I noticed that the priority of config.toolbar and config.removeButtons is different in the toolbar configurator than in the toolbar plugin. E.g:

	config.toolbar = [ [ 'Source', 'Undo' ] ];
	config.removeButtons = 'Undo';

In such case CKEditor renders only 'Source' button, while the toolbar configurator (the editor) includes both.

I think though, that we can ignore this case, because it may happen, but it isn't correct.

[Piotrek Koszuliński]

Fixed on major with ​git:ba216e3.