Opened 10 years ago
Closed 10 years ago
#13173 closed Bug (fixed)
[Adv. toolbar conf] config.removeButtons is ignored
Reported by: | Piotrek Koszuliński | Owned by: | Artur Delura |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.0 |
Component: | Toolbar Configurator | Version: | 4.5.0 Beta |
Keywords: | Cc: |
Description
- Build basic preset.
- Open the adv toolbar configurator
- See that in the toolbar there are no undo and redo buttons but there are in the source.
- Switch to the basic configurator and see that it correctly disables those buttons.
Change History (10)
comment:1 Changed 10 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 10 years ago by
Owner: | set to Artur Delura |
---|---|
Status: | confirmed → assigned |
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
COnfig listed above is translated to
CKEDITOR.editorConfig = function( config ) { config.toolbar = [ { name: 'clipboard', items: [ 'Undo', 'Redo' ] }, { name: 'links', items: [ 'Link', 'Unlink', 'Anchor' ] } ]; config.removeButtons = 'Undo,Redo,Anchor'; }
but do we really should handle removeButtons
in adv toolbar configurator? I think we shuld end up with
CKEDITOR.editorConfig = function( config ) { config.toolbar = [ { name: 'links', items: [ 'Link', 'Unlink' ] } ]; }
It's simpler more logical - Why add things and remove them at once?
comment:5 Changed 10 years ago by
Yes, I've been thinking about removing these buttons which are listed in config.removeButtons in config.js from the config.toolbar table that you can see in the configurator.
comment:7 Changed 10 years ago by
Status: | assigned → review |
---|
comment:8 Changed 10 years ago by
Component: | General → Toolbar Configurator |
---|
comment:9 Changed 10 years ago by
Status: | review → review_passed |
---|
I noticed that the priority of config.toolbar and config.removeButtons is different in the toolbar configurator than in the toolbar plugin. E.g:
config.toolbar = [ [ 'Source', 'Undo' ] ]; config.removeButtons = 'Undo';
In such case CKEditor renders only 'Source' button, while the toolbar configurator (the editor) includes both.
I think though, that we can ignore this case, because it may happen, but it isn't correct.
comment:10 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed on major with git:ba216e3.
To reproduce this issue on dev version we need to update a config.js to