Opened 10 years ago
Closed 10 years ago
#13199 closed Bug (fixed)
Embedsemantic does not support widget classes
| Reported by: | Piotrek Koszuliński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 4.5.0 |
| Component: | General | Version: | 4.5.0 Beta |
| Keywords: | Cc: |
Description
Classes are neither read nor printed to the source.
The embed plugin should be reviewed as well.
Change History (6)
comment:1 Changed 10 years ago by
| Priority: | Normal → High |
|---|---|
| Status: | new → confirmed |
comment:2 Changed 10 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 10 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
I was able to simplify the way how classes are copied to the downcasted element.
Fixed on major with git:d31d1be.
comment:5 Changed 10 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Turns out we were close to a disaster with this one. We totally forgot that widget styles must be registered in the filter and for that a special properties styleableElements or styleToAllowedContentRules must be set. We didn't catch this, because this worked well in the embed widget because the whole div[data-oembed-url] is skipped by the filter. But it didn't work at all with embedsemantic, so classes were still filtered out.
comment:6 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Fixed on major with git:251f830.
Note: See
TracTickets for help on using
tickets.
branch:t/13199